FIX: Correct HMAC validation
This commit is contained in:
@ -11,13 +11,6 @@ class HMAC extends Ideal\Service
|
||||
$encodedSecret = mb_convert_encoding($secret, 'UTF-8');
|
||||
$encodedMessage = mb_convert_encoding($message, 'UTF-8');
|
||||
$hmacObject = hash_hmac('sha256', $encodedMessage, $encodedSecret);
|
||||
$computedSignature = base64_encode($hmacObject);
|
||||
$this->logger->info('Validating HMAC', [
|
||||
'requestSignature' => $requestSignature,
|
||||
'computedSignature' => $hmacObject,
|
||||
'compare1' => hash_equals($hmacObject, $requestSignature),
|
||||
'compare2' => hash_equals($computedSignature, $requestSignature),
|
||||
]);
|
||||
return hash_equals($computedSignature, $requestSignature);
|
||||
return hash_equals($hmacObject, $requestSignature);
|
||||
}
|
||||
}
|
Reference in New Issue
Block a user