Correct Exceptions

This commit is contained in:
Juan Pablo Vial
2025-06-06 17:37:42 -04:00
parent 13b246b998
commit 5134630525
2 changed files with 7 additions and 8 deletions

View File

@ -6,6 +6,7 @@ use DateTimeZone;
use InvalidArgumentException; use InvalidArgumentException;
use OutOfRangeException; use OutOfRangeException;
use Psr\Log\LoggerInterface; use Psr\Log\LoggerInterface;
use Predis\Connection\ConnectionException;
use Incoviba\Common\Ideal; use Incoviba\Common\Ideal;
use Incoviba\Common\Implement\Exception\EmptyRedis; use Incoviba\Common\Implement\Exception\EmptyRedis;
use Incoviba\Common\Implement\Exception\EmptyResult; use Incoviba\Common\Implement\Exception\EmptyResult;
@ -36,7 +37,7 @@ class Job extends Ideal\Service
}); });
} }
return array_map([$this, 'load'], $jobs); return array_map([$this, 'load'], $jobs);
} catch (EmptyRedis) { } catch (ConnectionException | EmptyRedis) {
return []; return [];
} }
} }

View File

@ -28,7 +28,7 @@ class Queue extends Ideal\Service
try { try {
$this->jobService->add($configuration); $this->jobService->add($configuration);
return true; return true;
} catch (Create $exception) { } catch (Read $exception) {
$final = new Exception("Could not enqueue job", 0, $exception); $final = new Exception("Could not enqueue job", 0, $exception);
$this->logger->warning($final); $this->logger->warning($final);
return false; return false;
@ -82,12 +82,10 @@ class Queue extends Ideal\Service
} }
public function run(?RequestInterface $request = null): bool public function run(?RequestInterface $request = null): bool
{ {
try { $jobs = $this->jobService->getPending();
$jobs = $this->jobService->getPending(); if (count($jobs) === 0) {
} catch (Read $exception) { $this->logger->debug("No pending jobs");
$final = new Exception("Could not get pending jobs", 0, $exception); return true;
$this->logger->warning($final);
return false;
} }
$errors = []; $errors = [];